(DOCSP-42573) Update transactions in Functions info about read/write settings #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransaction session
✅ Deploy Preview for app-services ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dacharyc
approved these changes
Oct 2, 2024
| @@ -1,10 +1,10 @@ | |||
| exports = function () { | |||
| const client = context.services.get("mongodb-atlas"); | |||
|
|
|||
| db = client.db("exampleDatabase"); | |||
| const db = client.db("exampleDatabase"); | |||
There was a problem hiding this comment.
Well-spotted! Nice fixups - thank you! 🙏
| @@ -439,7 +431,7 @@ To perform a transaction: | |||
| } | |||
|
|
|||
| The following example creates two users, "henry" and "michelle", and | |||
| a uses a transaction to move "browniePoints" between those users | |||
| uses a transaction to move "browniePoints" between those users | |||
There was a problem hiding this comment.
Ooo, another good spot - nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing any mentions + code of creating a configuration object that sets user's preferred read/write settings and passing it to the session method. These settings are not configured in this context and not respected.
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-42573
Staging Links
Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
Review Guidelines
REVIEWING.md