chore(deps): bump mongosh VSCODE-548 #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Jun 27, 2024
| "@mongosh/browser-runtime-electron": "^2.2.10", | ||
| "@mongosh/i18n": "^2.2.10", | ||
| "@mongosh/service-provider-server": "^2.2.10", | ||
| "@mongosh/shell-api": "^2.2.10", |
There was a problem hiding this comment.
Should this bump the driver and mongodb-data-service as well? Typically, our release flow is:
- Driver package(s) is released
- (If necessary) Bump driver in oidc-plugin
- (If necessary) Bump driver, oidc-plugin in devtools-connect
- Bump driver, oidc-plugin, devtools-connect in mongosh
- Bump driver, oidc-plugin, devtools-connect, mongosh in Compass packages (e.g. data-service)
- Bump driver, oidc-plugin, devtools-connect, mongosh, data-service in VSCode
so that all packages in the source tree are on consistent versions of the driver
There was a problem hiding this comment.
add these deps were updated in #734 and only mongosh were left out (probably due to failing ts).
There was a problem hiding this comment.
Yes #734 is merged, so main should have those bumped by now.
alenakhineika
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump mongosh and also install types for sinon-chai to resolve ts issue (check ticket comments).
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes