chore(ci): move draft releases to github actions #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Jan 1, 2024
There was a problem hiding this comment.
Sweet, nice changes. One thing on documentation we probably want to look at:
In our CONTRIBUTING.md document in this repo we write about the release process. With these changes we should update that releasing section so that its not out of date.
https://github.com/mongodb-js/vscode/blob/main/CONTRIBUTING.md#releasing
Anemy
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to move also this one to CI, and be fully managed via Github actions, the set of privileges is the same of pushing tags, this is more practical and accessible for people not actively working on vscode (ie. first responder, a PM @GaurabAryal :))
The idea is to kickoff draft releases from https://github.com/mongodb-js/vscode/actions selecting the type of bump (patch, minor, major) from a dropdown or the exact new version.
The workflow has safe-guard checks for pre-existing tags and version format.
NOTE: To do this i've extracted the test and build steps in a composite action, which is called by test and set and create draft release.