Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds a new overview screen based on LeafyGreen components VSCODE-485 #617

Merged
merged 10 commits into from
Dec 1, 2023
Merged

feat: adds a new overview screen based on LeafyGreen components VSCODE-485 #617

merged 10 commits into from
Dec 1, 2023

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Nov 30, 2023 •
edited
Loading

Description

In this PR, we have created a new overview screen using LeafyGreen components, as per design spec.

Mode Before After
Dark image image
Dark image image
Dark image image
Light image image
Light image image
Light image image

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@himanshusinghs himanshusinghs requested a review from Anemy November 30, 2023 14:50
Anemy
Anemy reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a couple small comments, nothing major. Nice work, I dig the hook usages.

src/views/webview-app/connection-status.tsx Show resolved Hide resolved
src/test/suite/views/webview-app/connect-helper.test.tsx Outdated Show resolved Hide resolved
src/views/webview-app/resources-panel/header.tsx Show resolved Hide resolved
src/views/webview-app/overview-header.tsx Outdated Show resolved Hide resolved
src/views/webview-app/use-connection-status.ts Outdated Show resolved Hide resolved
src/views/webview-app/connection-status.tsx Show resolved Hide resolved
src/views/webview-app/atlas-logo.tsx Outdated Show resolved Hide resolved
src/views/webviewController.ts Outdated Show resolved Hide resolved
@himanshusinghs himanshusinghs merged commit 12bc65a into main Dec 1, 2023
5 checks passed
@himanshusinghs himanshusinghs deleted the VSCODE-485-new-overview-screen branch December 1, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshusinghs @Anemy