Skip to content

Commit

Permalink
update method for more accurate naming
Browse files Browse the repository at this point in the history
  • Loading branch information
Anemy committed Dec 18, 2023
1 parent b543926 commit 705aa7b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions src/connectionController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export default class ConnectionController {
);

try {
const connectResult = await this.saveNewConnectionFromFormAndConnect(
const connectResult = await this.saveNewConnectionAndConnect(
{
id: uuidv4(),
connectionOptions: {
Expand Down Expand Up @@ -235,8 +235,7 @@ export default class ConnectionController {
});
}

// TODO: Save from form / connection string...
async saveNewConnectionFromFormAndConnect(
async saveNewConnectionAndConnect(
originalConnectionInfo: ConnectionInfoFromLegacyDS,
connectionType: ConnectionTypes
): Promise<ConnectionAttemptResult> {
Expand Down
4 changes: 2 additions & 2 deletions src/views/webviewController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class WebviewController {
const connectionInfo =
this._connectionController.parseNewConnection(rawConnectionModel);
const { successfullyConnected, connectionErrorMessage } =
await this._connectionController.saveNewConnectionFromFormAndConnect(
await this._connectionController.saveNewConnectionAndConnect(
connectionInfo,
ConnectionTypes.CONNECTION_FORM
);
Expand Down Expand Up @@ -159,7 +159,7 @@ export default class WebviewController {
) => {
try {
const { successfullyConnected, connectionErrorMessage } =
await this._connectionController.saveNewConnectionFromFormAndConnect(
await this._connectionController.saveNewConnectionAndConnect(
connectionInfo,
ConnectionTypes.CONNECTION_FORM
);
Expand Down

0 comments on commit 705aa7b

Please sign in to comment.