fixup: remove comments, update test naming

mongodb-js · Jan 12, 2024 · 65335f2 · 65335f2
1 parent 80e8a7f
commit 65335f2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/telemetry/telemetryService.ts b/src/telemetry/telemetryService.ts
@@ -74,6 +74,10 @@ type KeytarSecretsMigrationFailedProperties = {
   connections_with_failed_keytar_migration: number;
 };
 
+type ConnectionEditedTelemetryEventProperties = {
+  success: boolean;
+};
+
 type SavedConnectionsLoadedProperties = {
   // Total number of connections saved on disk
   saved_connections: number;
@@ -92,6 +96,7 @@ export type TelemetryEventProperties =
   | ExtensionCommandRunTelemetryEventProperties
   | NewConnectionTelemetryEventProperties
   | DocumentUpdatedTelemetryEventProperties
+  | ConnectionEditedTelemetryEventProperties
   | DocumentEditedTelemetryEventProperties
   | QueryExportedTelemetryEventProperties
   | PlaygroundCreatedTelemetryEventProperties

diff --git a/src/test/suite/views/webviewController.test.ts b/src/test/suite/views/webviewController.test.ts
@@ -560,7 +560,7 @@ suite('Webview Test Suite', () => {
     await testConnectionController.disconnect();
   });
 
-  test('calls to edit the active connection when an edit connection message is passed', async () => {
+  test('calls to edit a connection when an edit connection message is passed', async () => {
     let messageReceived;
 
     sandbox.stub(testTelemetryService, 'trackNewConnection');

diff --git a/src/views/webview-app/connection-form.tsx b/src/views/webview-app/connection-form.tsx
@@ -44,7 +44,6 @@ const ConnectionForm: React.FunctionComponent<
   {
     isConnecting: boolean;
     onCancelConnectClicked: () => void;
-    // onConnectClicked: ['onConnectClicked'];
     onClose: () => void;
     open: boolean;
     connectionErrorMessage: string;