test

mongodb-js · Oct 9, 2024 · 4143a75 · 4143a75
1 parent 2702b72
commit 4143a75
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 20 deletions.
diff --git a/src/legacy_wrappers/cursors.js b/src/legacy_wrappers/cursors.js
@@ -25,15 +25,9 @@ module.exports.makeLegacyFindCursor = function (baseClass) {
       return maybeCallback(super.count(options), callback);
     }
 
-    explain(verbosity, callback) {
-      callback =
-        typeof callback === 'function'
-          ? callback
-          : typeof verbosity === 'function'
-            ? verbosity
-            : undefined;
-      verbosity = typeof verbosity !== 'function' ? verbosity : undefined;
-      return maybeCallback(super.explain(verbosity), callback);
+    explain(_verbosity, _options, _callback) {
+      const callback = Array.from(arguments).find(argument => typeof argument === 'function');
+      return maybeCallback(super.explain(...arguments), callback);
     }
 
     close(options, callback) {
@@ -180,15 +174,9 @@ module.exports.makeLegacyAggregationCursor = function (baseClass) {
   }
 
   class LegacyAggregationCursor extends baseClass {
-    explain(verbosity, callback) {
-      callback =
-        typeof callback === 'function'
-          ? callback
-          : typeof verbosity === 'function'
-            ? verbosity
-            : undefined;
-      verbosity = typeof verbosity !== 'function' ? verbosity : undefined;
-      return maybeCallback(super.explain(verbosity), callback);
+    explain(_verbosity, _options, _callback) {
+      const callback = Array.from(arguments).find(argument => typeof argument === 'function');
+      return maybeCallback(super.explain(...arguments), callback);
     }
 
     close(options, callback) {

diff --git a/test/tools/api.js b/test/tools/api.js
@@ -38,7 +38,7 @@ const api = [
   { className: 'Admin', method: 'serverStatus', returnType: 'Promise<Document>' },
   { className: 'Admin', method: 'validateCollection', returnType: 'Promise<Document>' },
 
-  { className: 'AggregationCursor', method: 'explain', returnType: 'Promise<Document>' },
+  { className: 'AggregationCursor', method: 'explain', returnType: 'Promise<Document>', possibleCallbackPositions: [1, 2, 3] },
   { className: 'AggregationCursor', method: 'clone', returnType: 'AggregationCursor', notAsync: true },
 
   { className: 'FindCursor', method: 'clone', returnType: 'FindCursor', notAsync: true },
@@ -115,7 +115,7 @@ const api = [
   { className: 'Db', method: 'watch', returnType: 'ChangeStream', notAsync: true },
 
   { className: 'FindCursor', method: 'count', returnType: 'Promise<number>' },
-  { className: 'FindCursor', method: 'explain', returnType: 'Promise<Document>' },
+  { className: 'FindCursor', method: 'explain', returnType: 'Promise<Document>', possibleCallbackPositions: [1,2,3] },
 
   { className: 'GridFSBucket', method: 'delete', returnType: 'Promise<void>', possibleCallbackPositions: [1, 2] },
   { className: 'GridFSBucket', method: 'drop', returnType: 'Promise<void>', possibleCallbackPositions: [1, 2] },