Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser-repl): use an error background color that makes syntax highlighting legible COMPASS-8308 #2307

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

djechlin-mongodb
Copy link
Contributor

@djechlin-mongodb djechlin-mongodb commented Dec 19, 2024

These changes are requested by design:

  1. The light red background should remain the darker background.
  2. The initial error declaration should be light red not dark red.
  3. The first line of the error, and the initial text, should be white.
  4. There should be a light red indent bar (in css, a left border) to the left of the stack.

New, better:

image

Old, worse:

image

@djechlin-mongodb djechlin-mongodb marked this pull request as ready for review December 19, 2024 23:03
@djechlin-mongodb djechlin-mongodb merged commit 0919d39 into main Dec 20, 2024
129 of 137 checks passed
@djechlin-mongodb djechlin-mongodb deleted the COMPASS-8308 branch December 20, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants