fix: suppress experimental warning for node 23 MONGOSH-1895 #2258
Conversation
nirinchev
changed the title
nirinchev
force-pushed
the
ni/experimental-warning
branch
from
41ba8b9 to
d24f7a3
Compare
nirinchev
force-pushed
the
ni/experimental-warning
branch
from
6d8c714 to
b5ac5cc
Compare
| @@ -7132,7 +7132,7 @@ functions: | |||
| { | |||
| export NODE_JS_VERSION=${node_js_version} | |||
| source .evergreen/setup-env.sh | |||
| export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD="true" | |||
| export PUPPETEER_SKIP_DOWNLOAD="true" | |||
There was a problem hiding this comment.
Apparently, PUPPETEER_SKIP_CHROMIUM_DOWNLOAD had been deprecated and it seems to have been removed altogether (couldn't find any reference to it in the puppeteer version we're using). See puppeteer/puppeteer#11069.
.github/workflows/homebrew.yml
Outdated
| on: | ||
| schedule: | ||
| - cron: "0 0 * * *" | ||
| pull_request: # TODO: remove pull_request trigger |
There was a problem hiding this comment.
Waiting on IT to create the webhook, after which I'll clean up the TODOs in this file.
| @@ -397,7 +397,7 @@ async function runSmokeTest({ | |||
| // eslint-disable-next-line | |||
| const { spawn } = require('child_process') as typeof import('child_process'); | |||
| const proc = spawn(executable, [...args], { | |||
| stdio: ['pipe', 'pipe', includeStderr ? 'pipe' : 'inherit'], | |||
| stdio: 'pipe', | |||
There was a problem hiding this comment.
Changing to pipe indiscriminately so that we can then validate there's no warnings in stderr.
| executable, | ||
| actualExitCode, | ||
| args: args.map((arg) => redactURICredentials(arg)), | ||
| }; | ||
| try { | ||
| assert.match(includeStderr ? `${stdout}\n${stderr}` : stdout, output); | ||
| assert.doesNotMatch(stderr, /ExperimentalWarning/); |
There was a problem hiding this comment.
I'm tempted to change this to match more broadly just Warning, but I'm not sure if that might result in false positives.
.github/workflows/homebrew.yml
Outdated
| - run: mongosh --smokeTests | ||
| - name: Report failure | ||
| # TODO: replace with failure() | ||
| if: ${{ success() }} |
There was a problem hiding this comment.
Yeah, I'll fix that before we merge - just wanted to test it first once I get the slack webhook from IT.
package.json
Outdated
| @@ -167,4 +169,4 @@ | |||
| "overrides": { | |||
| "cookie": "^0.7.2" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Missing newline at end of file?
There was a problem hiding this comment.
Ugh, will need to take a look at my vscode settings - I thought it was prettier that removes it 😬
Co-authored-by: Anna Henningsen <[email protected]>
|
I've removed the homebrew smoke test workflow and will re-add it in a separate PR. Addressed comments as well, so I'm going to go ahead and merge this so we can reap some of the benefits, particularly around reduced CI times due to the chromium downloads (in my tests, shaves 3-4 minutes from each |
brew install mongoshand then smoke test it