chore: re-enable startup snapshot support MONGOSH-1605 #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves adding nodejs/node@e54ddf898f6c as a (cleanly applying) patch but otherwise seems to work just fine.
lerouxb
approved these changes
Feb 28, 2024
vorsel
added a commit
to vorsel/mongosh-packaging
that referenced
this pull request
Apr 1, 2024
1. use npm@9 2. switch from "useNodeSnapshot" to "useCodeCache": The reported issue is related to the fact that upstream switched to use "useNodeSnapshot" and created their own patch for nodejs v20.x.x. That was done in scope of mongodb-js/mongosh#1842 https://jira.mongodb.org/browse/MONGOSH-1605. Another related issue is https://jira.mongodb.org/browse/MONGOSH-1604. From our end we use nodejs v16.x.x(in order to be able to build for old systems like centos7), so the upstream patch is not applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves adding nodejs/node@e54ddf898f6c as a (cleanly applying) patch but otherwise seems to work just fine.