Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npm i, not npm ci #1782

Closed
wants to merge 1 commit into from
Closed

chore: use npm i, not npm ci #1782

wants to merge 1 commit into from

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Jan 9, 2024

Follow-up to #1780

I changed npm i to npm ci at the last minute, after I last tested this manually and it gives an error:
https://spruce.mongodb.com/task/mongosh_linux_unit_compile_ts_659c3bafe3c3310b835871aa_24_01_08_18_15_11/logs?execution=0

[2024/01/08 18:17:36.729] npm verb stack Error:
[2024/01/08 18:17:36.729] npm verb stack `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
[2024/01/08 18:17:36.729] npm verb stack
[2024/01/08 18:17:36.729] npm verb stack Invalid: lock file's [email protected] does not satisfy [email protected]

I was trying to avoid doing install rather than ci because of the npm run mark-ci-required-optional-dependencies lower down, but that's probably unavoidable.

@lerouxb
Copy link
Contributor Author

lerouxb commented Jan 15, 2024

New plan: undo the changes to evergreen.yml, change evergreen-nightly-driver.yml to just test the nightly driver on ubuntu only. Don't try and refactor evergreen.yml because that would just be a mess. Have a single script rather.

@lerouxb lerouxb closed this Jan 15, 2024
@lerouxb lerouxb deleted the install_not_ci branch January 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant