Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shell-api): handle db name conflicts with Object.prototype MONGOSH-1630 #1726

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix(shell-api): handle db name conflicts with Object.prototype MONGOSH-1630 #1726

merged 2 commits into from
Nov 10, 2023

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Nov 7, 2023

No description provided.

kmruiz
kmruiz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@kmruiz kmruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy trick using Object.create(null) to not have a prototype, never seen it but it's cool.

@addaleax addaleax merged commit 2ed7a90 into main Nov 10, 2023
2 checks passed
@addaleax addaleax deleted the 1630-dev branch November 10, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmruiz kmruiz kmruiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @kmruiz