Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: try and make the test aggregation more complicated so it doesn't drop 'stages' from the explain plan MONGOSH-1635 #1725

Merged
merged 2 commits into from
Nov 8, 2023
Merged

chore: try and make the test aggregation more complicated so it doesn't drop 'stages' from the explain plan MONGOSH-1635 #1725

merged 2 commits into from
Nov 8, 2023

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Nov 7, 2023 •
edited
Loading

The latest alpha seems to have changed things:

[2023/11/06 15:51:29.306]   3) Shell API (integration)
[2023/11/06 15:51:29.306]        collection
[2023/11/06 15:51:29.306]          aggregate
[2023/11/06 15:51:29.306]            runs an explain with explain: queryPlanner:
[2023/11/06 15:51:29.306]       AssertionError: expected { explainVersion: '2', …(5), …(2) } to contain keys 'ok', and 'stages'
[2023/11/06 15:51:29.306]       + expected - actual
[2023/11/06 15:51:29.306]        [
[2023/11/06 15:51:29.306]       -  "command"
[2023/11/06 15:51:29.306]       -  "explainVersion"
[2023/11/06 15:51:29.306]          "ok"
[2023/11/06 15:51:29.306]       -  "queryPlanner"
[2023/11/06 15:51:29.306]       -  "serverInfo"
[2023/11/06 15:51:29.306]       -  "serverParameters"
[2023/11/06 15:51:29.306]       +  "stages"
[2023/11/06 15:51:29.306]        ]

@lerouxb lerouxb changed the title chore: try and make the test aggregation more complicated so it doesn't drop 'stages' from the explain plan chore: try and make the test aggregation more complicated so it doesn't drop 'stages' from the explain plan MONGOSH-1635 Nov 8, 2023
@lerouxb lerouxb merged commit b780455 into main Nov 8, 2023
2 checks passed
@lerouxb lerouxb deleted the fix-aggregation-explain-tests branch November 8, 2023 13:43
@addaleax addaleax mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lerouxb @addaleax