Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(async-rewriter): allow cursor iteration with for-of MONGOSH-1527 #1698

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat(async-rewriter): allow cursor iteration with for-of MONGOSH-1527 #1698

merged 2 commits into from
Oct 19, 2023

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Oct 4, 2023 •
edited
Loading

Still needs tests.

@addaleax addaleax changed the title [WIP] feat(async-rewriter): allow cursor iteration with for-of MONGOSH-1527 feat(async-rewriter): allow cursor iteration with for-of MONGOSH-1527 Oct 5, 2023
@addaleax addaleax marked this pull request as ready for review October 5, 2023 12:38
Anemy
Anemy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tried it out on local and works good (And the async iterables!).

@addaleax addaleax merged commit 9d3d25b into main Oct 19, 2023
2 checks passed
@addaleax addaleax deleted the 1527-dev branch October 19, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @Anemy