Skip to content

Commit

Permalink
fix(build): set NODE_JS_VERSION in Unix CI (#398)
Browse files Browse the repository at this point in the history
Otherwise, we just build with any newer Node.js 12.x version,
unlike Windows.

This bug led to the 0.5.1 release happening with Node.js 12.18.4
on Windows and Node.js 12.19.0 on other platforms.
Let’s pick a consistent version. Pick 12.18.4 rather than 12.19.0
because we’re currently seeing Node.js deprecation warnings being
shown with 12.19.0 (until
mongodb-js/boxednode#9 is merged).
  • Loading branch information
addaleax authored Nov 11, 2020
1 parent c81dccd commit 90ab136
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .evergreen/.setup_env
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
set -e
export NODE_JS_VERSION='12.18.4'
export NVM_DIR="$HOME/.nvm"
echo "Setting NVM environment home: $NVM_DIR"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
Expand Down

0 comments on commit 90ab136

Please sign in to comment.