Skip to content

Commit

Permalink
Remove eperm workaround
Browse files Browse the repository at this point in the history
  • Loading branch information
nirinchev committed Dec 4, 2024
1 parent ab1f394 commit 53508e0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
5 changes: 0 additions & 5 deletions packages/e2e-tests/test/e2e-auth.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
skipIfApiStrict,
startSharedTestServer,
} from '../../../testing/integration-testing-hooks';
import { skipDueToEPermErrors } from './util-helpers';

type AssertUserExists = (opts?: Document, username?: string) => Promise<void>;
function createAssertUserExists(db: Db, dbName: string): AssertUserExists {
Expand Down Expand Up @@ -1054,8 +1053,6 @@ describe('Auth e2e', function () {
shell.assertNoErrors();
});
it('cannot auth when authenticationMechanism mismatches (sha256 -> sha1)', async function () {
skipDueToEPermErrors(this);

const connectionString = await testServer.connectionString();
shell = this.startTestShell({
args: [
Expand All @@ -1077,8 +1074,6 @@ describe('Auth e2e', function () {
});
});
it('cannot auth when authenticationMechanism mismatches (sha1 -> sha256)', async function () {
skipDueToEPermErrors(this);

const connectionString = await testServer.connectionString();
shell = this.startTestShell({
args: [
Expand Down
5 changes: 1 addition & 4 deletions packages/e2e-tests/test/e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { createServer as createHTTPServer } from 'http';
import { once } from 'events';
import type { AddressInfo } from 'net';
const { EJSON } = bson;
import { skipDueToEPermErrors, sleep } from './util-helpers';
import { sleep } from './util-helpers';

const jsContextFlagCombinations: `--jsContext=${'plain-vm' | 'repl'}`[][] = [
[],
Expand Down Expand Up @@ -1046,8 +1046,6 @@ describe('e2e', function () {
});

it('reads and runs code from stdin, with .end()', async function () {
skipDueToEPermErrors(this);

const dbName = `test-${Date.now()}`;
shell.process.stdin.end(`
use ${dbName};
Expand All @@ -1061,7 +1059,6 @@ describe('e2e', function () {
});

it('reads and runs the vscode extension example playground', async function () {
skipDueToEPermErrors(this);
createReadStream(
path.resolve(__dirname, 'fixtures', 'exampleplayground.js')
).pipe(shell.process.stdin);
Expand Down
7 changes: 0 additions & 7 deletions packages/e2e-tests/test/util-helpers.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
export function sleep(ms: number): Promise<void> {
return new Promise((resolve) => setTimeout(resolve, ms));
}

export function skipDueToEPermErrors(context: Mocha.Context): void {
if (process.platform === 'win32' && process.versions.node.startsWith('22')) {
// This test fails on Windows with node 22 likely due to https://github.com/nodejs/node/issues/51766
return context.skip();
}
}

0 comments on commit 53508e0

Please sign in to comment.