Add a comment

mongodb-js · Nov 6, 2024 · 43efe22 · 43efe22
1 parent 0549169
commit 43efe22
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/cli-repl/src/cli-repl.ts b/packages/cli-repl/src/cli-repl.ts
@@ -1287,6 +1287,8 @@ export class CliRepl implements MongoshIOProvider {
         latest:
           await this.updateNotificationManager.getLatestVersionIfMoreRecent(''),
         currentVersion,
+        hasGreetingCTA:
+          !!(await this.updateNotificationManager.getGreetingCTAForCurrentVersion()),
       });
     } catch (err: any) {
       this.bus.emit('mongosh:error', err, 'startup');

diff --git a/packages/cli-repl/src/update-notification-manager.ts b/packages/cli-repl/src/update-notification-manager.ts
@@ -184,9 +184,13 @@ export class UpdateNotificationManager {
       latestKnownMongoshVersion: this.latestKnownMongoshVersion,
       cta: {
         [currentVersion]: this.currentVersionGreetingCTA,
-        ...(this.latestKnownMongoshVersion && {
-          [this.latestKnownMongoshVersion]: latestKnownVersionCTA,
-        }),
+
+        // Add the latest known version's CTA if we're not already on latest. This could be used
+        // next time we start mongosh if the user has updated to latest.
+        ...(this.latestKnownMongoshVersion &&
+          this.latestKnownMongoshVersion !== currentVersion && {
+            [this.latestKnownMongoshVersion]: latestKnownVersionCTA,
+          }),
       },
     };
     await fs.writeFile(localFilePath, JSON.stringify(localFileContents));

diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -179,6 +179,7 @@ export interface FetchingUpdateMetadataEvent {
 export interface FetchingUpdateMetadataCompleteEvent {
   latest: string | null;
   currentVersion: string;
+  hasGreetingCTA: boolean;
 }
 
 export interface SessionStartedEvent {