Skip to content

Commit

Permalink
feat: replace Node.js REPL with plain vm context for script usage MON…
Browse files Browse the repository at this point in the history 
…GOSH-1720 (#1849)

- Allow running `MongoshNodeRepl` instances either based on:
  - The existing mechanism for running code, which is spinning up
    a Node.js REPL and using it to evaluate code; or
  - A more lightweight mechanism that only creates a `vm` context
    and then run code using that context directly.
- Introduce a new command-line switch, `--jsContext`, that can be
  used to explicitly select the desired behavior, with possible values
  of `repl`, `plain-vm` and `auto`. The default behavior is to switch
  depending on whether the CLI will enter interactive mode or not.

Running in `plain-vm` mode will significantly improve runtime
performance (a 6× reduction of script run time in local testing),
coming from the removal of async context tracking that the REPL
uses to identify async operations which were originally spawned
from the REPL instance in question.

This lack of async context tracking comes with some implications,
in particular asynchronously thrown errors (in the Node.js sense,
e.g. `setImmediate(() => { throw ... })`) will lead to slightly
different behavior (e.g. different error code and error output).
That is probably acceptable breakage in this context.
  • Loading branch information
@addaleax
addaleax authored Mar 6, 2024
1 parent 20df659 commit 21f7968
Show file tree
Hide file tree
Showing 12 changed files with 606 additions and 299 deletions.
1 change: 1 addition & 0 deletions packages/arg-parser/src/cli-options.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export interface CliOptions {
help?: boolean;
host?: string;
ipv6?: boolean;
jsContext?: 'repl' | 'plain-vm' | 'auto';
json?: boolean | 'canonical' | 'relaxed';
keyVaultNamespace?: string;
kmsURL?: string;
Expand Down
1 change: 1 addition & 0 deletions packages/cli-repl/src/arg-parser.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const OPTIONS = {
'gssapiServiceName',
'sspiHostnameCanonicalization',
'sspiRealmOverride',
'jsContext',
'host',
'keyVaultNamespace',
'kmsURL',
Expand Down
281 changes: 160 additions & 121 deletions packages/cli-repl/src/cli-repl.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -590,135 +590,174 @@ describe('CliRepl', function () {
});
});

context('files loaded from command line', function () {
it('load a file if it has been specified on the command line', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello1.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include(`Loading file: ${filename1}`);
expect(output).to.include('hello one');
expect(exitCode).to.equal(0);
});
for (const jsContext of ['repl', 'plain-vm', undefined] as const) {
context(
`files loaded from command line (jsContext: ${
jsContext ?? 'default'
})`,
function () {
beforeEach(function () {
cliReplOptions.shellCliOptions.jsContext = jsContext;
});
it('load a file if it has been specified on the command line', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello1.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include(`Loading file: ${filename1}`);
expect(output).to.include('hello one');
expect(exitCode).to.equal(0);
});

it('load two files if it has been specified on the command line', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello1.js'
);
const filename2 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello2.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1, filename2];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include(`Loading file: ${filename1}`);
expect(output).to.include('hello one');
expect(output).to.include(`Loading file: ${filename2}`);
expect(output).to.include('hello two');
expect(exitCode).to.equal(0);
});
it('load two files if it has been specified on the command line', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello1.js'
);
const filename2 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello2.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1, filename2];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include(`Loading file: ${filename1}`);
expect(output).to.include('hello one');
expect(output).to.include(`Loading file: ${filename2}`);
expect(output).to.include('hello two');
expect(exitCode).to.equal(0);
});

it('does not print filenames if --quiet is passed', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello1.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1];
cliReplOptions.shellCliOptions.quiet = true;
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).not.to.include('Loading file');
expect(output).to.include('hello one');
expect(exitCode).to.equal(0);
});
it('does not print filenames if --quiet is passed', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'hello1.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1];
cliReplOptions.shellCliOptions.quiet = true;
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).not.to.include('Loading file');
expect(output).to.include('hello one');
expect(exitCode).to.equal(0);
});

it('forwards the error it if loading the file throws', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'throw.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1];
cliRepl = new CliRepl(cliReplOptions);
try {
await cliRepl.start('', {});
} catch (err: any) {
expect(err.message).to.include('uh oh');
}
expect(output).to.include('Loading file');
expect(output).not.to.include('uh oh');
});
it('forwards the error it if loading the file throws', async function () {
const filename1 = path.resolve(
__dirname,
'..',
'test',
'fixtures',
'load',
'throw.js'
);
cliReplOptions.shellCliOptions.fileNames = [filename1];
cliRepl = new CliRepl(cliReplOptions);
try {
await cliRepl.start('', {});
} catch (err: any) {
expect(err.message).to.include('uh oh');
}
expect(output).to.include('Loading file');
expect(output).not.to.include('uh oh');
});

it('evaluates code passed through --eval (single argument)', async function () {
cliReplOptions.shellCliOptions.eval = ['"i am" + " being evaluated"'];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include('i am being evaluated');
expect(exitCode).to.equal(0);
});
it('evaluates code passed through --eval (single argument)', async function () {
cliReplOptions.shellCliOptions.eval = [
'"i am" + " being evaluated"',
];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include('i am being evaluated');
expect(exitCode).to.equal(0);
});

it('forwards the error if the script passed to --eval throws (single argument)', async function () {
cliReplOptions.shellCliOptions.eval = ['throw new Error("oh no")'];
cliRepl = new CliRepl(cliReplOptions);
try {
await cliRepl.start('', {});
} catch (err: any) {
expect(err.message).to.include('oh no');
}
expect(output).not.to.include('oh no');
});
it('forwards the error if the script passed to --eval throws (single argument)', async function () {
cliReplOptions.shellCliOptions.eval = [
'throw new Error("oh no")',
];
cliRepl = new CliRepl(cliReplOptions);
try {
await cliRepl.start('', {});
} catch (err: any) {
expect(err.message).to.include('oh no');
}
expect(output).not.to.include('oh no');
});

it('evaluates code passed through --eval (multiple arguments)', async function () {
cliReplOptions.shellCliOptions.eval = [
'X = "i am"; "asdfghjkl"',
'X + " being evaluated"',
];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.not.include('asdfghjkl');
expect(output).to.include('i am being evaluated');
expect(exitCode).to.equal(0);
});
it('evaluates code passed through --eval (multiple arguments)', async function () {
cliReplOptions.shellCliOptions.eval = [
'X = "i am"; "asdfghjkl"',
'X + " being evaluated"',
];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.not.include('asdfghjkl');
expect(output).to.include('i am being evaluated');
expect(exitCode).to.equal(0);
});

it('forwards the error if the script passed to --eval throws (multiple arguments)', async function () {
cliReplOptions.shellCliOptions.eval = [
'throw new Error("oh no")',
'asdfghjkl',
];
cliRepl = new CliRepl(cliReplOptions);
try {
await cliRepl.start('', {});
} catch (err: any) {
expect(err.message).to.include('oh no');
it('forwards the error if the script passed to --eval throws (multiple arguments)', async function () {
cliReplOptions.shellCliOptions.eval = [
'throw new Error("oh no")',
'asdfghjkl',
];
cliRepl = new CliRepl(cliReplOptions);
try {
await cliRepl.start('', {});
} catch (err: any) {
expect(err.message).to.include('oh no');
}
expect(output).to.not.include('asdfghjkl');
expect(output).not.to.include('oh no');
});

it('evaluates code in the expected environment (non-interactive)', async function () {
cliReplOptions.shellCliOptions.eval = [
'print(":::" + (globalThis[Symbol.for("@@mongosh.usingPlainVMContext")] ? "plain-vm" : "repl"))',
];
cliRepl = new CliRepl(cliReplOptions);
await startWithExpectedImmediateExit(cliRepl, '');
expect(output).to.include(`:::${jsContext ?? 'plain-vm'}`);
expect(exitCode).to.equal(0);
});

if (jsContext !== 'plain-vm') {
it('evaluates code in the expected environment (interactive)', async function () {
cliReplOptions.shellCliOptions.eval = [
'print(":::" + (globalThis[Symbol.for("@@mongosh.usingPlainVMContext")] ? "plain-vm" : "repl"))',
];
cliReplOptions.shellCliOptions.shell = true;
cliRepl = new CliRepl(cliReplOptions);
await cliRepl.start('', {});
input.write('exit\n');
await waitBus(cliRepl.bus, 'mongosh:closed');
expect(output).to.include(`:::${jsContext ?? 'repl'}`);
expect(exitCode).to.equal(0);
});
}
}
expect(output).to.not.include('asdfghjkl');
expect(output).not.to.include('oh no');
});
});
);
}

context('in --json mode', function () {
beforeEach(function () {
Expand Down
Loading

0 comments on commit 21f7968

Please sign in to comment.