chore(mocha-config-devtools): bump jsdom to 22, global-jsdom to 9 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
commented
Oct 26, 2023
|
|
||
| describe('mocha-config-devtools/react', function () { | ||
| it('has jsdom', function () { | ||
| assert(!!globalThis.window); |
There was a problem hiding this comment.
A bit too basic, but just wanted to make sure globals are still exposed after a major version bump
gribnoysup
force-pushed
the
bump-jsdom-to-22
branch
from
175d157 to
821600c
Compare
Anemy
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried updating to check if latest jsdom can handle container queries, it doesn't, but probably still makes sense to update to latest