Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6606): install bson libraries to tmp directory #24

Merged
merged 7 commits into from
Dec 6, 2024
Merged

fix(NODE-6606): install bson libraries to tmp directory #24

merged 7 commits into from
Dec 6, 2024

Conversation

W-A-James
Copy link
Collaborator

@W-A-James W-A-James commented Nov 20, 2024 •
edited
Loading

Description

What is changing?

  • Change Package to install to provided install directory
  • Change Task to install to system tmp directory
  • Update mocha hooks to clear out configured install directory between tests
Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title ci(NODE-6559): add 22 to matrix and test on latest ci(NODE-6606): add 22 to matrix and test on latest Dec 5, 2024
@W-A-James W-A-James changed the title ci(NODE-6606): add 22 to matrix and test on latest fixNODE-6606): install bson libraries to tmp directory Dec 5, 2024
@W-A-James W-A-James changed the title fixNODE-6606): install bson libraries to tmp directory fix(NODE-6606): install bson libraries to tmp directory Dec 5, 2024
@W-A-James W-A-James mentioned this pull request Dec 5, 2024
Merged
5 tasks
@nbbeeken nbbeeken self-assigned this Dec 6, 2024
@nbbeeken nbbeeken added the Primary Review Pull request is being reviewed by primary reviewer label Dec 6, 2024
nbbeeken
nbbeeken requested changes Dec 6, 2024
View reviewed changes
packages/bson-bench/src/common.ts Outdated Show resolved Hide resolved
packages/bson-bench/src/task.ts Outdated Show resolved Hide resolved
packages/bson-bench/test/utils.ts Show resolved Hide resolved
@W-A-James W-A-James requested a review from nbbeeken December 6, 2024 19:44
@nbbeeken nbbeeken merged commit c61aa31 into main Dec 6, 2024
4 checks passed
@nbbeeken nbbeeken deleted the NODE-6559 branch December 6, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review Pull request is being reviewed by primary reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken