feature: add support for multi-region param #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, don't forget to add region to app:deploy |
maorb-dev
requested changes
May 23, 2024
maorb-dev
approved these changes
May 26, 2024
src/commands/app/deploy.ts
Outdated
Comment on lines
64
to
65
| const { directoryPath, appId, appVersionId, region: strRegion, force } = flags; | ||
| const region = getRegionFromString(strRegion); |
There was a problem hiding this comment.
Can also simplify things by getting rid of redundant const regionStr
Suggested change
| const { directoryPath, appId, appVersionId, region: strRegion, force } = flags; | |
| const region = getRegionFromString(strRegion); | |
| const { directoryPath, appId, appVersionId, force } = flags; | |
| const region = getRegionFromString(flags?.region); |
maorb-dev
approved these changes
May 28, 2024
maorb-dev
approved these changes
May 28, 2024
…multi_region_param # Conflicts: # package.json
…multi_region_param
* feature: add support for multi region param * feature: add support for multi region param * feature: update version * feature: [beta] added interactive * feature: [beta] added interactive * feature: [beta] added interactive * feature: [beta] added interactive * feature: [beta] added interactive * feature: fix name of type * feature: fix version * feature: fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3670992828/views/126769350/pulses/6667531207
add support for multi-region param