Fix: allow choosing live versions #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorShakedMonday
approved these changes
Jan 9, 2024
| @@ -46,10 +46,9 @@ export default class AppDeploy extends AuthenticatedCommand { | |||
| async getAppVersionId(appVersionId: string | undefined, appId: string | undefined, force: boolean): Promise<string> { | |||
| if (appVersionId) return appVersionId; | |||
|
|
|||
| const latestDraftVersion = await DynamicChoicesService.chooseAppAndAppVersion({ | |||
| const latestDraftVersion = await DynamicChoicesService.chooseAppAndAppVersion(false, Boolean(force), { | |||
There was a problem hiding this comment.
Suggested change
| const latestDraftVersion = await DynamicChoicesService.chooseAppAndAppVersion(false, Boolean(force), { | |
| const latestDraftVersion = await DynamicChoicesService.chooseAppAndAppVersion(false, !!force, { |
?
There was a problem hiding this comment.
ESLint: use Boolean(force) instead.(no-implicit-coercion)
Comment on lines
+48
to
+51
| async chooseAppAndAppVersion( | ||
| useDeprecatedVersion: boolean, | ||
| useLiveVersion: boolean, | ||
| options?: { appId?: number; autoSelectVersion?: boolean }, |
There was a problem hiding this comment.
General comment:
Transfering true, true can cause issues as well.
What do you say about having an object for the arguments? not optional, but an object for better readability
Suggested change
| async chooseAppAndAppVersion( | |
| useDeprecatedVersion: boolean, | |
| useLiveVersion: boolean, | |
| options?: { appId?: number; autoSelectVersion?: boolean }, | |
| async chooseAppAndAppVersion( | |
| { useDeprecatedVersion: boolean, | |
| useLiveVersion: boolean }, | |
| options?: { appId?: number; autoSelectVersion?: boolean }, |
This will make sure people understand what is true and what is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.