Support deploying-app and adjust progresses #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaikatzz
changed the title
shaikatzz
changed the title
maorb-dev
approved these changes
Aug 20, 2023
|
@shaikatzz also important to note, we have to make the corresponding changes in apps-backend and mndy-code repos, as they both keep enums for these "status" values, and might error in runtime when getting unknown values.. |
yep, checked locally and looks great.
Changes to apps-backend and mndy-code already deployed to accept this new deploying-app status last week. |
shaikatzz
deleted the
feature/shaika/support-deploying-app-and-ignore-building-infra
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.