Update VBO with user requests #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
katiermullen
commented
Sep 27, 2024
•
katiermullen
commented
- Address NTRs and edits - Cellosaurus #181 - add DSH and Japanese domestic cat
- Close Additional cat breeds #195 - additional cat breed synonyms
- Close Update GCCF and FIFe URLs/breed recognition status/breed codes for cat breeds #200 - update FIFe and GGCF URLs, breed codes
- Close Add synonym to http://purl.obolibrary.org/obo/VBO_0009377 #189 - add syn Australian Brown (Goat)
- Close Term request - pigeon #198 - two new pigeon breeds
- Close Term request - chicken #199 - add one new chicken breed
- Close Cat synonyms? #65 - Add mixed breed cat and children DSH/DLH/DMH, obsolete breed-registry specific terms that were out of scope
- Close New entry for VBO 'Rangeland Goats' #188 - add new goat breed - Rangeland
- Close Error in label and synonym of VBO:0005306? #164 - update label for -, Turkey (Cattle)
-Address #181 - add DSH and Japanese domestic cat -Close #195 - additional cat breed synonyms -Close #200 - update FIFe and GGCF URLs, breed codes -Close #189 - add syn Australian Brown (Goat) -Close #198 - two new pigeon breeds -Close #199 - add one new chicken breed -Close #65 - Add mixed breed cat and children DSH/DLH/DMH, obsolete breed-registry specific terms that were out of scope -Close#188 - add new goat breed - Rangeland -Close#164 - update label for -, Turkey (Cattle)
|
@sabrinatoro please review at your convenience. Not urgent. I just wanted to get the PR submitted so it is not hanging over me :) Instead it is hanging over you :) |
sabrinatoro
requested changes
Oct 15, 2024
There was a problem hiding this comment.
@katiermullen
This is fantastic! And it is a ton of work. Thank you!!!!
I only have one comment.
It looks like the following breed registration status was not updated for Nebelung (GCCF organization now says it is fully recognized). (from #200)
See ontology screenshot from this PR:
|
@sabrinatoro I have updated this PR with your requested change. Thank you for catching my mistake! |
sabrinatoro
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Looks good! Thank you @katiermullen.
Approving and merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.