Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata documentation #193

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Metadata documentation #193

merged 5 commits into from
Aug 2, 2024

Conversation

sabrinatoro
Copy link
Collaborator

No description provided.

@sabrinatoro sabrinatoro marked this pull request as draft July 31, 2024 02:40
@sabrinatoro sabrinatoro marked this pull request as ready for review July 31, 2024 23:23
katiermullen
katiermullen previously approved these changes Aug 1, 2024
Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabrinatoro I found a few typos, but otherwise the PR looks great. Thank you for doing this. I approve this PR once the small typos are addressed.


The “source” annotation for the database cross reference is the provenance for this mapping between VBO and the other source. Currently, the provenance is the ORCID of the contributor [link to contributor section] who manually curated this mapping.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a link to "contributor section" here or wait until "contributor section" is populated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update all the links later. Just because I don't know the best way to add the links (ie link to the repo or to the document).
Note that it is the same throughout the document.

docs/ontologymodeling/metadata.md Outdated Show resolved Hide resolved
docs/ontologymodeling/metadata.md Outdated Show resolved Hide resolved
docs/ontologymodeling/metadata.md Outdated Show resolved Hide resolved
docs/ontologymodeling/metadata.md Outdated Show resolved Hide resolved
docs/ontologymodeling/metadata.md Outdated Show resolved Hide resolved
@sabrinatoro
Copy link
Collaborator Author

Screenshot 2024-08-01 at 3 34 00 PM

@katiermullen I don't know how I did this, but it was obviously not on purpose! :-D
Could you please re-approve (and merge) if you still agree? Thank you

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sabrina! I approve your changes.

@katiermullen katiermullen merged commit b53e5cc into master Aug 2, 2024
1 check passed
@katiermullen katiermullen deleted the doc240730 branch August 2, 2024 15:23
@sabrinatoro sabrinatoro restored the doc240730 branch August 7, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants