Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new sheep breed and ref for Chilean Terrier #124

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add new sheep breed and ref for Chilean Terrier #124

merged 2 commits into from
Nov 21, 2023

Conversation

katiermullen
Copy link
Collaborator

Addresses #123 and #122

sabrinatoro
sabrinatoro previously approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please see comment about adding PMID for the most common name only or adding it also as a source for the whole breed.
If the

src/ontology/components/dogbreeds.tsv Show resolved Hide resolved
sabrinatoro
sabrinatoro approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. It is ready to merge!

@katiermullen katiermullen merged commit 539182f into master Nov 21, 2023
1 check passed
@katiermullen katiermullen deleted the 231107-australian-white branch November 21, 2023 16:46
This was referenced Nov 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrinatoro sabrinatoro sabrinatoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katiermullen @sabrinatoro