Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #893

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Update documentation #893

merged 8 commits into from
Nov 20, 2024

Conversation

ptgolden
Copy link
Member

@ptgolden ptgolden commented Nov 15, 2024

Summary

Related issues

Patrick Golden added 6 commits November 15, 2024 10:09
-o is typically the flag for outputting to a file, but it's best not to
change what's already there.

Additionally, a couple commands take -o as a different command line
option for specificying objects
There are a number of changes here that come as a result of 64b4d01.
Namely: the docstring of arguments are removed in favor of pulling help
from typer arguments and options.
This adds a new section to the navigation bar ("Release process"), and
merges the previous "Welcome" and "Usage" pages into a "monarch-py"
section.
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 4e579e5
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/673e16377c266a0008b3c082
😎 Deploy Preview https://deploy-preview-893--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (1a1350d) to head (4e579e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   71.14%   71.14%           
=======================================
  Files          91       91           
  Lines        3136     3136           
=======================================
  Hits         2231     2231           
  Misses        905      905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ptgolden ptgolden changed the title Issue 820 update docs Update documentation Nov 15, 2024
This commit does two things to complete the collection of all monarch-py
documentation into a single section in the main documentation. It does
the following:

1. Remove "API Reference" section. The information there is in the
   "Interfaces" and "Implementations" subsections of the monarch-py
   documentation.

2. Moves the "Response Data Model"-- which contains documentation
   generated from LinkML models-- into a "Data Model" subsection in
   monarch-py.

Besides the CLI documentation, the monarch-py documentation is a bit
jumbled and obviously needs some attention and changing. It's not quite
clear coming to the page how someone might use the package as a python
package. That is a broader issue, and not one we need to focus on right
now, since it's not clear that anyone but the Web application actually
uses the monarch-py code.
@ptgolden
Copy link
Member Author

@kevinschaper Do you want to check out this PR, build the docs, and see if this organization is to your liking?

@kevinschaper
Copy link
Member

@ptgolden it looks like this needs a slightly more careful merge to handle renaming entity to entity_id

@kevinschaper kevinschaper merged commit 16a4db4 into main Nov 20, 2024
9 checks passed
@kevinschaper kevinschaper deleted the issue-820-update-docs branch November 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the Monarch KG Release process page to the Monarch-app documentation
2 participants