Nginx UI integration #278
Merged
Nginx UI integration #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… image, other cleanups pre-PR
kevinschaper
approved these changes
Aug 15, 2023
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevinschaper
pushed a commit
that referenced
this pull request
Aug 16, 2023
This is a quick hotfix for PR #278. The previous version didn't pull all tags on checkout, so the workflow failed when it attempted to find the most recent git tag to set the image's tag.
kevinschaper
pushed a commit
that referenced
this pull request
Aug 22, 2023
### Related issues - Addresses #235 ### Summary This PR adds a Dockerfile to build an nginx-based container to serve the UI; the v3 deployment stack will deploy this image alongside the rest of the stack. The built UI bundle is baked into the image for ease of deployment. The PR piggybacks off of the existing `.github/workflows/deploy-frontend.yaml` workflow, since the frontend is built there. In that workflow, the Dockerfile mentioned previously is built as `us-central1-docker.pkg.dev/monarch-initiative/monarch-api/monarch-ui`. During the build, the UI bundle is copied into the image. The image is then pushed to the GCP Artifact registry, where it can be pulled by the v3 stack deployer. ### Checks - [x] All tests have passed (or issues created for failing tests)
kevinschaper
pushed a commit
that referenced
this pull request
Aug 22, 2023
This is a quick hotfix for PR #278. The previous version didn't pull all tags on checkout, so the workflow failed when it attempted to find the most recent git tag to set the image's tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
This PR adds a Dockerfile to build an nginx-based container to serve the UI; the v3 deployment stack will deploy this image alongside the rest of the stack. The built UI bundle is baked into the image for ease of deployment.
The PR piggybacks off of the existing
.github/workflows/deploy-frontend.yamlworkflow, since the frontend is built there. In that workflow, the Dockerfile mentioned previously is built asus-central1-docker.pkg.dev/monarch-initiative/monarch-api/monarch-ui. During the build, the UI bundle is copied into the image. The image is then pushed to the GCP Artifact registry, where it can be pulled by the v3 stack deployer.Checks