Correct disp format in catalog.py #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #45 by using valid values for disp_dic in catalog.py.
I think that these values have always been invalid, but astropy has not validated them before release 4.0.1 (see astropy/astropy#9978 ) so it hasn't raised any errors in the past and we've been feeding 'garbage' values into it until now. Considering that things have worked in the past even with invalid values here, maybe it's not actually too important..?
I don't know if the format in this commit makes much sense (it probably doesn't?) - I more or less arbitrarily copied it from the disp format used for OBSDATE. Still, astropy accepts it and thus it fixes the crash.