Static map list system #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
added
Size: Medium
tsa96
force-pushed
the
feat/map-list-flat-file
branch
from
c12027e to
744a1ae
Compare
tsa96
force-pushed
the
feat/map-list-flat-file
branch
from
744a1ae to
42b3eb5
Compare
tsa96
force-pushed
the
feat/map-list-flat-file
branch
3 times, most recently
from
efde006 to
4389688
Compare
tsa96
force-pushed
the
feat/map-list-flat-file
branch
from
4389688 to
1756e60
Compare
Panzerhandschuh
approved these changes
Mar 5, 2024
One of these days I will turn off the unicorn recommended config entirely...
tsa96
force-pushed
the
feat/map-list-flat-file
branch
5 times, most recently
from
ba319fb to
e71be81
Compare
… file extension fucking source
tsa96
force-pushed
the
feat/map-list-flat-file
branch
from
e71be81 to
3b7d75f
Compare
|
@Panzerhandschuh this is good to go now, a couple more commits since you last reviewed but they're very straightforward. I'll have another PR for filter map submissions in an hour or so, if you could check the latest stuff on this, then that PR, that'd be really appreciated. |
For some reason this was super slow, and the number of reports grew with number of users - very weird!
Sorry I'm so tired today and this PR makes multiple changes to this file so fixuping is a nightmare.
tsa96
force-pushed
the
feat/map-list-flat-file
branch
from
3b7d75f to
b0b7c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the backend site of static list system, which stores the entirely of the approved and in-submission maps in deflate compressed JSON files.
@Gocnak we should wait until your side of the this system is completed before we merge, just wanted to get this PR started.
@jason-e you were involved with discussions of this system, so feel free to have a look!