Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back,db): sets the initial level for users to 0 #881

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ianwillis98
Copy link
Contributor

Closes #877

Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, CI is happy! And like Nick said on your last PR, rather than open a new PR, if you need to make a change and don't want to muddy the commit log, you can stage any other changes, then do git commit --amend -no-edit to amend those changes onto your original commit, then git push --force to overwrite your original commit on remote (i.e. Github). If you have multiple commits it's a little more complicated, you need to do a git rebase --interactive and do fixups, but no need to worry about that here. If you're having any issues with Github, feel free to ask for help on here in your commit description (can you always amend/fixup) or in our Discord - Git isn't easy software to use and we're always happy to help.

I'm a little concerned by the fact the original starting XP was 20000, since I assume someone specifically chose that. But we're likely to tweak cosmetic XP a great deal in the future anyway, and it's not that major a change, let's just go ahead and get this in.

Congrats on your first PR!

@tsa96 tsa96 merged commit 389d3bb into momentum-mod:main Jan 2, 2024
6 checks passed
@tsa96
Copy link
Member

tsa96 commented Jan 2, 2024

Oh, and Nick if you're reading - I'm doing the eqiuv changes to the constants on red feat/mom-0.10 now. (edit: done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor XP systems code to allow being level 0
2 participants