-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign map upload form for 0.10.0 map submission #603
Comments
As per what was said on the discord in On top of that, probably gonna rework how the map file and map thumbnail buttons are, probably do something similar to the zones area where, after you add the file, it changes to a delete button. I'll play around with that. Just thought I should add these on here just in case they get lost in the channel history! |
Blocking off for now, as 0.10.0 map submission changes are bound to affect this in loads of different ways, so worth waiting until that's more specced out. Though the author search credits-related stuff is now being tracked in #759 instead, and can be worked on now. |
Okay, have updated the issue description with new stuff, should be good to go. I'm planning on working on this, but won't get to it for a couple of weeks at least. If anyone else is particularly keen, give me a shout. |
Map files and map submission versions should always start with the map's |
|
Current upload form is pretty crummy.- The zone file upload component should be grouped with all the other file uploads- The Youtube URL can move to its place in the "description" section- The authors search does not allow scrolling (limits to 5 people?) so searching for some common words never shows theprofile you need, especially placeholder accounts- Remove the "markdown is supported" bit. The game can't parse markdown and doesn't seem necessary.Additional ContextDiscussed in #website on 25/02/22.Note to contributors, this form is only visible to admins, so set your role to8
in the DB.Re-purposing this issue for the map submission project.
First, let's keep naming consistent and rename files/classes from "upload form" to "submission form".
"Files" page
Add a link to the map submission page on the docs - that will contain a detailed explanation of the entire process. Make sure the UI really nags people to read it. momentum-mod/docs#323
Entry for a VMF (optional), with an info tooltip saying that whilst uploading a VMF is not required, we encourage people be open with their maps, decompiling is possible anyway, and we that still have rules about stealing people's content.
Zones file should be here, not description page. We'll be storing zone data as JSON in the future, rather than KV1, which will make parsing much easier and mean we can remove the dependency on
node-steam/vdf
."Description" page
A "display name" entry, explaining difference between that and filename.
Youtube URL entry should be here, not Files.
A dropdown for "Submission Type" using the
MapSubmissionType
enum.A section for a new MapSubmissionSuggestions component, which should
ngFor
over everyGamemode
and provide an option forwith some descriptions for each (maybe easiest to put at the top of the section, not each instance)
We're gonna have a lot of submodes in the future so ideally have a quick way for people to hide modes they don't care about. Also we could use existing selections of modes to automatically hide modes they're incompatible with.
"Credits" page
Stays the same, the main improvements we're looking for here are coming in #415 and #768. I may clean up some of the Typescript in the credits components during #415, or even split up the editable and non-editable bits in separate components.
"Testing" page - NEW
Have a paragraph or two explaining how testing process works, and link to the docs page again.
Simple toggle button or something for whether they want private testing or not. If yes, show a user search component (note to self - if I'm working on this and #768 isn't in by then, may as well finish it up myself). Don't need to force people to add testers, they may want to do it later, not a big deal.
"Review" page
Not much new, just need to display all the new stuff.
The text was updated successfully, but these errors were encountered: