Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Priority Submissions #841

Closed
tsa96 opened this issue Aug 27, 2023 · 2 comments
Closed

High Priority Submissions #841

tsa96 opened this issue Aug 27, 2023 · 2 comments
Assignees

Comments

@tsa96
Copy link
Member

tsa96 commented Aug 27, 2023

Old backend had a system for setting a "high priority" property on maps. I didn't port it originally as frankly I didn't fully understand what it was (the implementation was quite weird). But we can definitely make it work, in fact it'll integrate a lot better with the new MapSubmission table. Doing this myself, given a quick spec here:

  • Add a boolean field for called highPriority (can't think of a reason to have more than two priority levels) on the MapSubmission table/model, default false.
  • Allow reviewer/mods/admins to filter by priority (undefined in query means no filtering)
  • Get rid of the two separate queue components on the admin map, just show it on a column in the list and have a dropdown to filter by on/off/none
  • Allow REVIEWERS to fast-track a map straight to FINAL_APPROVAL, skipping public testing. Allow admins/mods to approve a high priority map at any point after private testing (including if they're setting a map to high priority in that request).
@tsa96 tsa96 self-assigned this Aug 27, 2023
@tsa96 tsa96 converted this from a draft issue Aug 27, 2023
@tsa96
Copy link
Member Author

tsa96 commented Aug 27, 2023

In upload form (#603) and /maps POST, allow REVIEWERs and above to mark as high-priority

@tsa96 tsa96 moved this from In Progress to Todo in Map Submission Aug 29, 2023
@tsa96
Copy link
Member Author

tsa96 commented Sep 13, 2023

From discussion with Nick, we can't actually see much more

@tsa96 tsa96 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Map Submission Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant