Make curl honor the ~/.netrc file #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tknerr
commented
Oct 21, 2022
| @@ -268,7 +268,7 @@ COOKIE_FILE="$(mktemp)" | |||
| molior_session_call() | |||
| { | |||
| URL_PATH="$1" && shift | |||
| curl $MOLIOR_URL$URL_PATH -s --retry 10 \ | |||
| curl $MOLIOR_URL$URL_PATH -n -s --retry 10 \ | |||
There was a problem hiding this comment.
I'm not sure if we should add the -n here, because a few lines further down we explicitly pass the $MOLIOR_USERNAME and $MOLIOR_PASSWORD to curl (matching .netrc credentials will likely override these)
tknerr
commented
Oct 21, 2022
| @@ -41,7 +41,7 @@ COOKIE_FILE=`mktemp` | |||
| molior_session_call() | |||
| { | |||
| URL_PATH="$1" && shift | |||
| curl $MOLIOR_URL$URL_PATH -s --retry 10 \ | |||
| curl $MOLIOR_URL$URL_PATH -n -s --retry 10 \ | |||
There was a problem hiding this comment.
I'm not sure if we should add the -n here, because a few lines further down we explicitly pass the $MOLIOR_USERNAME and $MOLIOR_PASSWORD to curl (matching .netrc credentials will likely override these)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
-n(i.e.--netrc) flag to allcurlinvocations across all molior-tools scripts.With the
-nflag present,curlwill honor the presence of a~/.netrcfile and will read the login information from there.~/.netrcis present, curl will silently ignore that and continue without authentication~/.netrcis present, but no matching "machine" entry found, curl will silently ignore that and continue without authentication~/.netrcis present and a matching "machine" entry is found, it will authenticate with the "username" + "password" specified thereThis allows you:
molior-deploy -m https://my.mirror.org ...molior -p /my/apt/mirror.list ...)See also:
https://everything.curl.dev/usingcurl/netrc