-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poc/methylation #301
base: main
Are you sure you want to change the base?
Poc/methylation #301
Changes from all commits
6ca9c49
83858c6
e56ec47
93d42f9
9bbd462
bb43115
46a8411
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { WindowApiClient } from "@molgenis/vip-report-api/src/WindowApiClient"; | ||
import { WindowApiClient } from "../../vip-report-api/src/WindowApiClient"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this required when using a linked library? |
||
|
||
// lazy import MockApiClient to ensure that it is excluded from the build artifact | ||
const api = import.meta.env.PROD | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,8 +33,8 @@ export const GnomAD: Component<FieldProps> = (props) => { | |
<Anchor href={href}> | ||
<FieldValueFloat value={af()} /> | ||
</Anchor> | ||
<Show when={qc().length > 0}> | ||
<abbr title={"Failed quality control filters: " + qc().join(", ")} class="ml-1 is-clickable"> | ||
<Show when={qc() != null && qc().length > 0}> | ||
<abbr title="Failed quality control filters: <workaround:disabled>" class="ml-1 is-clickable"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note to self: due to a bug in vip-report-template that has been fixed on the main branch |
||
<i class="fas fa-circle-exclamation has-text-warning" /> | ||
</abbr> | ||
</Show> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.