Fix #67 Dropped trailing FORMAT values

molgenis · Nov 8, 2021 · 1dd830d · 1dd830d
1 parent f731be6
commit 1dd830d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@molgenis/vip-report-api",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "description": "Report API for Variant Call Format (VCF) Report Templates",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/vcf/SampleDataParser.ts b/src/vcf/SampleDataParser.ts
@@ -28,7 +28,7 @@ export function parseRecordSample(
   const parts = token.split(':');
 
   const recordSample: RecordSample = {};
-  for (let i = 0; i < formatFields.length; ++i) {
+  for (let i = 0; i < parts.length; ++i) {
     const field = formatFields[i];
     recordSample[field] = parseFormatValue(parts[i], formatMetadataContainer[field]);
   }

diff --git a/src/vcf/__tests__/SampleDataParser.test.ts b/src/vcf/__tests__/SampleDataParser.test.ts
@@ -79,3 +79,12 @@ test('parse record sample', () => {
     })
   ).toStrictEqual({ GT: { a: [0, 1], p: true, t: 'het' }, DP: 5 });
 });
+
+test('parse record sample - drop trailing fields', () => {
+  expect(
+    parseRecordSample('0|1', ['GT', 'DP'], {
+      GT: gtFormatMetadata,
+      DP: dpFormatMetadata
+    })
+  ).toStrictEqual({ GT: { a: [0, 1], p: true, t: 'het' } });
+});