-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritizing non-coding variants #84
Draft
dennishendriksen
wants to merge
23
commits into
main
Choose a base branch
from
feat/annotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue for VipVaranScore. Tests are commented for testing of annotation. created new annotation class VipScoreAnnotator for the annotation of the VipVaranScore Removed travis.yml
// level 1: overlap with a region // level 2: level 1 + score of ncER(>0.499) fathmm(>0.5) ReMM*(>0.5) // level 3: level 2 + constraint region above or equal to 0.7
And moved logic for determining a good tool score to methods
Created Interface classes for VipScoreAnnotator and VipScoreAnnotatorFactory. Created factory class for VipScoreannotator. Modified the Classifier interface and factory to handle VipScoreAnnotator
… the test accordingly
// level 0: nothing // level 1: overlap with a region or a constraint value above or equal to 0.7 or a score of ncER(>49.9) fathmm(>0.5) ReMM*(>0.5) // level 2: score of ncER(>49.9) fathmm(>0.5) ReMM*(>0.5) and overlap with a region or a constraint value above or equal to 0.7 // level 3: level 2 + constraint region above or equal to 0.7 changed tests accordingly
Changed the example.vcf and example-classified.vcf to comply with the new expected input and output.
…d how it determines a score per variant
…he new functionality
…also taken into account, updated the tests accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internship project from @JonathanKlimp on prioritizing non-coding variants (report can be downloaded here)