feat: form validation link file #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marikaris
changed the title
erikzwart
previously requested changes
Oct 17, 2024
There was a problem hiding this comment.
Functional test on preview, created a Project cohort and folder test. Uploaded nonrep.parquet. The buton 'Create view' does not work:
After selecting 'Create view':
Also tried the button 'Select table to link from ..', here I can select the source project, folder and table but after that I see the same empty screen as above.
I'm not able to test the form validation because the form is not shown.
…re gone from preview
marikaris
force-pushed
the
feat/form-validation-link-file
branch
from
002b53f to
d94ee2e
Compare
timcadman
approved these changes
Oct 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how to test:
todo: