Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #774 when unauthorised, provide clear warning message #802

Merged
merged 5 commits into from
Oct 21, 2024
Merged

fix: #774 when unauthorised, provide clear warning message #802

merged 5 commits into from
Oct 21, 2024

Conversation

marikaris
Copy link
Collaborator

@marikaris marikaris commented Oct 14, 2024 •
edited
Loading

how to test:

  • go to http://localhost:8080
  • log in with user/password
  • go to user screen uncheck your oidc account as admin
  • login to your oidc account
  • see warning message

todo:

  • code ok

@marikaris marikaris linked an issue Oct 14, 2024 that may be closed by this pull request
When user is not an admin, unclear error appears in UI #774
Closed
@marikaris marikaris changed the title fix: #774 when unauthorised, don't show tabs and give clear error mes… fix: #774 when unauthorised, provide clear warning message Oct 15, 2024
mswertz
mswertz approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code okay

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@marikaris marikaris merged commit b2f47e0 into master Oct 21, 2024
3 checks passed
@marikaris marikaris deleted the fix/774-unclear-error-when-unauthorised branch October 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When user is not an admin, unclear error appears in UI
2 participants
@marikaris @mswertz