Merge pull request #557 from molgenis/bug/test-on-host-port-combo

Test on port and host.
molgenis · Nov 23, 2023 · 201b843 · 201b843
2 parents 4ad5b8d + fae5646
commit 201b843
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/ui/src/views/Profiles.vue b/ui/src/views/Profiles.vue
@@ -303,11 +303,15 @@ export default defineComponent({
         return profile.name;
       });
 
-      const portAlreadyUsed = this.profiles.some((prof) => {
-        return prof !== profile && prof.port == profile.port;
-      });
-      if (portAlreadyUsed) {
-        this.errorMessage = `Save failed: port number [${profile.port}] already used.`;
+      const hostPortCombo = `${profile.host}:${profile.port}`;
+
+      const hasDuplicates = this.profiles.some(
+        (prof) =>
+          prof !== profile && `${prof.host}:${prof.port}` === hostPortCombo
+      );
+
+      if (hasDuplicates) {
+        this.errorMessage = `Save failed: [${hostPortCombo}] already used.`;
         return;
       }
 

diff --git a/ui/tests/unit/views/Profiles.spec.ts b/ui/tests/unit/views/Profiles.spec.ts
@@ -224,7 +224,7 @@ describe("Profiles", () => {
         wrapper.vm.profiles.unshift(p);
         wrapper.vm.profileToEditIndex = 0;
         wrapper.vm.saveEditedProfile();
-        expect(wrapper.vm.errorMessage).toBe("Save failed: port number [6313] already used.");
+        expect(wrapper.vm.errorMessage).toBe("Save failed: [localhost:6313] already used.");
     });
 
     test("fail to save a unnamed profile", () => {