Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc(beacon): configurable templates for beacon api #4536

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

harmbrugge
Copy link
Member

@harmbrugge harmbrugge commented Dec 2, 2024

#4533

What are the main changes you did

  • Added a templates table in the system schema
  • Added a templates tab in "Admin > Templates" to configure the templates
  • Load default templates in db from templates at classpath.
  • Beacon api looks for a custom template or else picks the default template.

How to test

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@harmbrugge harmbrugge self-assigned this Dec 2, 2024
@connoratrug
Copy link
Contributor

maybe move into existing app ( central , admin, ui, ..) to avoid copy pasting app setup, build config, components, dependancies,..

@harmbrugge harmbrugge marked this pull request as draft December 3, 2024 12:41
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poc(beacon): editable templates to map api templates on a datamodel
2 participants