Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable testExecuteSubtaskInScriptTask test, unstalbe in CI co… #4522

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

connoratrug
Copy link
Contributor

…ntext

What are the main changes you did

  • explain what you changed and essential considerations.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@harmbrugge
Copy link
Member

Should we try to give it a bit more time, before disabling it?

@mswertz
Copy link
Member

mswertz commented Nov 28, 2024

Is it only the subtask test? Because might this then be a bug?

Generally, can you please work with @harmbrugge to move these integration tests to a seperate job analogous to e2e? (i.e. using the preview server and then testing from outside)?

@connoratrug
Copy link
Contributor Author

Is it only the subtask test? Because might this then be a bug?

Generally, can you please work with @harmbrugge to move these integration tests to a seperate job analogous to e2e? (i.e. using the preview server and then testing from outside)?

Yes , we have discussed this

Copy link

@mswertz
Copy link
Member

mswertz commented Nov 28, 2024

@harmbrugge kun je hier story voor aanmaken in github?

@connoratrug connoratrug merged commit 4fa0010 into master Nov 28, 2024
6 checks passed
@connoratrug connoratrug deleted the chore/disable-flacky-test branch November 28, 2024 08:57
@connoratrug
Copy link
Contributor Author

@harmbrugge kun je hier story voor aanmaken in github?

had ik aan gedaan en Harm ge@

@connoratrug
Copy link
Contributor Author

see: #4523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants