fix(tw): select input component rewrite #4337
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mswertz
changed the title
chinook25
reviewed
Oct 24, 2024
Comment on lines
+2
to
+5
| interface ISelectOptions { | ||
| value: string | number; | ||
| label?: string; | ||
| } |
There was a problem hiding this comment.
As I currently am building a screen where I want to use this component, I would like to insert objects with label as one of its fields. Would you be against adding this?
connoratrug
reviewed
Nov 4, 2024
|
|
||
| withDefaults( | ||
| defineProps<{ | ||
| id: string; | ||
| modelValue: string | number; | ||
| options: string[] | number[]; | ||
| selectOptions: ISelectOptions[]; |
There was a problem hiding this comment.
note this changes the public api, all use cases need to be updated
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
how to test:
todo: