Setup.py to pyproject.toml #166
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed setup of CAPICE from setup.py to pyproject.toml, including configuration for different tools
Need a better way to patch the CAPICE version now
# Conflicts: # setup.py # src/molgenis/capice/__init__.py
- Updated the capice project to use pyproject.toml instead of setup.py which will become deprecated.
…al "extra", specific to CI.
|
Kudos, SonarCloud Quality Gate passed! |
svandenhoek
requested changes
Mar 16, 2023
| "Molgenis <[email protected]>" | ||
| ] | ||
| readme = "README.md" | ||
| license = "LICENSE" |
There was a problem hiding this comment.
| ] | ||
| build-backend = "poetry.core.masonry.api" | ||
|
|
||
| [tool.poetry] |
There was a problem hiding this comment.
| [build-system] | ||
| requires = [ | ||
| "wheel", | ||
| "poetry-core" |
There was a problem hiding this comment.
Not sure if new releases pushed to Pypi through Travis works well with Poetry by default with the deploy step. We gotta make sure we don't break this (f.e. due to a manifest file not being interpreted in case of capice-resources repo).
…roject_toml # Conflicts: # pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOP
Changed
Important notes
include, which is something that setuptools can not function with yet. This means that non-python project files will not be included in the final build (either wheel or sdist).src) are included in a wheel / sdist after building.Before merge:
After merge: