fix: Update default type for ServiceSchema generic to Service<S>.

[marceliwac]

📝 Description

Fix for the default type for ServiceSchema generic which was previously set to void, causing problems when This type was not provided. The type should have defaulted to Service<S>.

🎯 Relevant issues

Fixes #1297.

Original PR which introduced the problem #1272.

💎 Type of change

• Bug fix (non-breaking change which fixes an issue)

📜 Example code

Given this example setup:

interface GreeterSettings extends ServiceSettingSchema {
        defaultName: string;
}

interface GreeterMethods {
        uppercase(str: string): string;
        other(): void;
}

interface GreeterLocalVars {
        myVar: string;
}

type GreeterThis = Service<GreeterSettings> & GreeterMethods & GreeterLocalVars;

This used to be causing the problems for the following cases:

// Without providing types for ServiceSchema at all
const GreeterService: ServiceSchema = {
        // ...
}

// Without providing `T` generic, default of `void` for "This" type caused problems.
const GreeterService: ServiceSchema<GreeterSettings> = {
        // ...
}

While the following was the only working use-case:

// Explicitly providing T generic worked as expected
const GreeterService: ServiceSchema<GreeterSettings, GreeterThis> = {
        // ...
}

Applying this patch fixes the problem for following cases:

// Without providing types for ServiceSchema at all
const GreeterService: ServiceSchema = {
        // ...
}

// Without providing `T` generic, default of `Service<S>` allows for the code to work as expected.
const GreeterService: ServiceSchema<GreeterSettings> = {
        // ...
}

// Explicitly providing T generic worked as expected
const GreeterService: ServiceSchema<GreeterSettings, GreeterThis> = {
        // ...
}

🚦 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Tested locally against TypeScript compiler (version 4.9.4).
• Tested locally against tsd (version 0.22.0).
• Added unit tests that verify the types set for lifecycle handlers in different scenarios (when schema provides setting type, schema provides setting type and this type, schema provides no type).

🏁 Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have commented my code, particularly in hard-to-understand areas

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/moleculerjs/moleculer@1299

commit: efb777c

[MichaelErmer]

Any updates on this? 🤔

[marceliwac]

I think it's up to the maintainers to merge this now. I suppose given the discussions in #1272 and #1297 @icebob will probably get around to it when he's got some time.

[MichaelErmer]

@icebob any idea when this can be released? we are currently stuck on 0.14.33 😨

[icebob]

I waited for somebody to test it in his project after merging and before releasing it, but I haven't received any feedback.

[icebob]

I've just released it as 0.14.35