Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple mongoose connections for service with schema and modelName #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle multiple mongoose connections for service with schema and modelName #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/moleculer-db-adapter-mongoose/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class MongooseDbAdapter {
*/
connect() {
let conn;
let multipleConns;

if (this.model) {
/* istanbul ignore next */
Expand All @@ -77,19 +78,20 @@ class MongooseDbAdapter {
}
} else if (this.schema) {
conn = new Promise(resolve =>{
const c = mongoose.createConnection(this.uri, this.opts);
const c = mongoose.createConnection(this.uri, this.opts);
this.model = c.model(this.modelName, this.schema);
multipleConns = c;
resolve(c);
});
}

return conn.then(() => {
this.conn = mongoose.connection;
this.conn = multipleConns || mongoose.connection;

if (mongoose.connection.readyState != mongoose.connection.states.connected) {
if (this.conn.readyState != this.conn.states.connected) {
throw new MoleculerError(
`MongoDB connection failed . Status is "${
mongoose.connection.states[mongoose.connection._readyState]
this.conn.states[this.conn._readyState]
}"`
);
}
Expand All @@ -98,7 +100,7 @@ class MongooseDbAdapter {
this.model = mongoose.model(this.model["modelName"],this.model["schema"]);
}

this.db = mongoose.connection.db;
this.db = this.conn.db;

if (!this.db) {
throw new MoleculerError("MongoDB connection failed to get DB object");
Expand All @@ -108,9 +110,9 @@ class MongooseDbAdapter {


/* istanbul ignore next */
mongoose.connection.on("disconnected", () => this.service.logger.warn("Mongoose adapter has disconnected."));
mongoose.connection.on("error", err => this.service.logger.error("MongoDB error.", err));
mongoose.connection.on("reconnect", () => this.service.logger.info("Mongoose adapter has reconnected."));
this.conn.on("disconnected", () => this.service.logger.warn("Mongoose adapter has disconnected."));
this.conn.on("error", err => this.service.logger.error("MongoDB error.", err));
this.conn.on("reconnect", () => this.service.logger.info("Mongoose adapter has reconnected."));

});
}
Expand Down
5 changes: 1 addition & 4 deletions packages/moleculer-db-adapter-mongoose/test/unit/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,7 @@ if (process.versions.node.split(".")[0] < 14) {
mongoose.createConnection = jest.fn(() => {
mongoose.connection.readyState =
mongoose.connection.states.connected;
return {
connection: { db: fakeDb, ...fakeDb },
model: jest.fn(() => fakeModel),
};
return mongoose.connection;
});

adapter.opts = {
Expand Down