Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Remove obsolete scripts - backup runfolder now in automated_scripts, … #42

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

RachelDuffin
Copy link
Contributor

@RachelDuffin RachelDuffin commented Mar 14, 2024

…findfastqs.sh not needed

This PR is in conjunction with the automated_scripts v45.0.0 release, as the backup runfolder script now resides in the automated_scripts repo. The find fastqs script is not needed


This change is Reviewable

Copy link
Contributor

@natashapinto natashapinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RachelDuffin)

Copy link
Contributor

@natashapinto natashapinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RachelDuffin)


README.md line 70 at r1 (raw file):

## License

Developed by Viapath Genome Informatics

Could we change it to Synnovis please

Copy link
Contributor Author

@RachelDuffin RachelDuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @natashapinto)


README.md line 70 at r1 (raw file):

Previously, natashapinto (Natasha Pinto) wrote…

Could we change it to Synnovis please

Done

Copy link
Contributor

@natashapinto natashapinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RachelDuffin)

Copy link
Contributor

@natashapinto natashapinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RachelDuffin)

@natashapinto natashapinto merged commit d4162fd into master Jun 7, 2024
2 checks passed
@natashapinto natashapinto deleted the remove_osbolete_scripts branch June 7, 2024 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants