Estimating backend #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariana0pachon
added
the
do not merge
mariana0pachon
force-pushed
the
mpp/display_stories
branch
6 times, most recently
from
72666e9 to
5936af8
Compare
mariana0pachon
force-pushed
the
mpp/estimate_backend
branch
2 times, most recently
from
763feea to
658277f
Compare
mariana0pachon
removed
the
do not merge
mariana0pachon
force-pushed
the
mpp/estimate_backend
branch
from
658277f to
c36115a
Compare
cbarber
reviewed
Aug 1, 2019
server/app/models/project.rb
Outdated
|
|
||
| def self.join_user_project(user:, project:) | ||
| p = Project.find_by(id: project.id) | ||
| p = Project.create!(id: project.id) if p.nil? |
There was a problem hiding this comment.
find_or_create_by. I think this would move the need for this method entirely:
user.projects << Project.find_or_create_by(id: project.id)
There was a problem hiding this comment.
Yeah I don't think this method is used at all... so I will just get rid of it. We do this instead:
pr = Project.find_or_initialize_by(id: p.id)
pr.name = p.name
pr.save!
self.projects << pr
where self is a User
server/app/models/story.rb
Outdated
| end | ||
|
|
||
| est | ||
| else { message: 'Invalid point value for this project\'s schema' } |
There was a problem hiding this comment.
Nit: move the object return to a line beneath else
| } | ||
|
|
||
| const EstimateSelect = ({ projectId, storyId }: Props) => { | ||
| const state = useStore().getState(); |
There was a problem hiding this comment.
Does this actually update on state changes? I thought we needed useSelector for a different issue.
| if (res.fetching) { | ||
| return <>Loading GraphQL...</>; | ||
| } else if (res.error) { | ||
| console.log(res.error); |
There was a problem hiding this comment.
console.error and you'll need a tslint.disable-next-line no-console comment.
mariana0pachon
force-pushed
the
mpp/estimate_backend
branch
from
c36115a to
bca5934
Compare
mariana0pachon
force-pushed
the
mpp/estimate_backend
branch
from
bca5934 to
349cfb7
Compare
mariana0pachon
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNM until base branch #14 is mergedThings to fix:
Estimateis not invalidated by URQL from the beginning, so once something appears there it does not know how to handle it. But this might not be the problem, because I tried reloading the page when the database is populated and nothing was shown either.