Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if result from ros1 goal handle is valid #17

Merged
merged 1 commit into from
Nov 7, 2023
Merged

check if result from ros1 goal handle is valid #17

merged 1 commit into from
Nov 7, 2023

Conversation

benmaidel
Copy link

fmessmer
fmessmer requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has linter errors....

@benmaidel benmaidel force-pushed the fix/invalid_shared_future branch from 03339da to 61648e9 Compare November 7, 2023 10:39
@benmaidel benmaidel force-pushed the fix/invalid_shared_future branch from 61648e9 to a49beb6 Compare November 7, 2023 11:51
@fmessmer fmessmer merged commit 77b8e2f into mojin-robotics:mojin-devel Nov 7, 2023
1 check passed
@benmaidel benmaidel deleted the fix/invalid_shared_future branch November 7, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmaidel @fmessmer