fix: avoid 2 extra db requests #1054
Conversation
kalinkrustev
requested review from
mdebarros,
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
|
| const cyrilOutput = await this.cyril.processFxFulfilMessage(transfer.commitRequestId, payload) | ||
| if (!transfer.fxWatchListId) { | ||
| throw new Error(`Commit request ID ${transfer.commitRequestId} not found in watch list`) | ||
| } |
There was a problem hiding this comment.
Can we still have a function in cyril 'processFxFulfilMessage' for this check? I mean. you can remove the call 'getAllDetailsByCommitRequestId' in that function, but I would recommend the queries (getItemInWatchListByCommitRequestId) on watchlist in the cyril functions instead of having a join in other place. Because the watchlist logic may change and I wouldn't suggest merging watchList in the places other than cyril. I know it's additional query but I hope it will not impact performance that much compared to left join.
| @@ -90,9 +90,11 @@ const getAllDetailsByCommitRequestId = async (commitRequestId) => { | |||
| .leftJoin('fxTransferStateChange AS tsc', 'tsc.commitRequestId', 'fxTransfer.commitRequestId') | |||
| .leftJoin('transferState AS ts', 'ts.transferStateId', 'tsc.transferStateId') | |||
| .leftJoin('fxTransferFulfilment AS tf', 'tf.commitRequestId', 'fxTransfer.commitRequestId') | |||
| .leftJoin('fxWatchList AS wl', 'wl.commitRequestId', 'fxTransfer.commitRequestId') | |||
There was a problem hiding this comment.
Please see my above comment.
No description provided.